Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Barracuda to 2.3.1-preview #5591

Merged
merged 2 commits into from
Oct 27, 2021
Merged

Upgrade Barracuda to 2.3.1-preview #5591

merged 2 commits into from
Oct 27, 2021

Conversation

hvpeteet
Copy link
Contributor

@hvpeteet hvpeteet commented Oct 20, 2021 •
edited
Loading

Proposed change(s)

Upgrade Barracuda references to 2.3.1-preview

Used #5291 #5305 #5343 as references.

⚠️ This is my first time doing this PLEASE TRIPPLE CHECK

Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)

Internal JIRA: https://jira.unity3d.com/browse/MLA-2253

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other: Upgrade dependency

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

Other comments

@hvpeteet hvpeteet marked this pull request as ready for review October 20, 2021 16:15
miguelalonsojr
miguelalonsojr approved these changes Oct 20, 2021
View reviewed changes
Copy link
Collaborator

@miguelalonsojr miguelalonsojr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's wait until tomorrow to merge to make sure nightly training passes, but otherwise, should be good to go.

maryamhonari
maryamhonari approved these changes Oct 20, 2021
View reviewed changes
Copy link
Contributor

@maryamhonari maryamhonari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hvpeteet
Copy link
Contributor Author

Running some CI jobs manually. Will merge before official CI kicks off today

@hvpeteet hvpeteet changed the title Upgrade Barracuda to 2.3.0-preview Upgrade Barracuda to 2.3.1-preview Oct 27, 2021
Upgrade to 2.3.1-preview
83f8c1a 
2.3.0-preview had a bug that was fixed. See JIRA ticket.
@hvpeteet
Copy link
Contributor Author

Upgraded to 2.3.1-preview after bug was found in 2.3.0-preview. See https://unity.slack.com/archives/CAFUH1CQN/p1635265775006100

@hvpeteet
Copy link
Contributor Author

Ran some experiments with inference and they finished (unlike with 2.3.0).

@hvpeteet hvpeteet merged commit bf3649f into main Oct 27, 2021
@delete-merged-branch delete-merged-branch bot deleted the develop-barracuda-2.3.0-preview branch October 27, 2021 15:15
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@maryamhonari maryamhonari maryamhonari approved these changes

@miguelalonsojr miguelalonsojr miguelalonsojr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hvpeteet @maryamhonari @miguelalonsojr